[webkit-reviews] review granted: [Bug 55414] Fix race condition in 4 media tests : [Attachment 84134] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 28 15:28:04 PST 2011
Darin Adler <darin at apple.com> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 55414: Fix race condition in 4 media tests
https://bugs.webkit.org/show_bug.cgi?id=55414
Attachment 84134: Patch
https://bugs.webkit.org/attachment.cgi?id=84134&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84134&action=review
Looks OK as long as the waitForEvent function is only ever used on events that
are unique enough.
> LayoutTests/media/video-test.js:3
> -var mediaElement = null;
> +var mediaElement = document;
This is pretty strange; expedient but pretty unclear! Probably needs a comment.
More information about the webkit-reviews
mailing list