[webkit-reviews] review denied: [Bug 54969] [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation : [Attachment 83828] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Robert Sesek
<rsesek at chromium.org>'s request for review:
Bug 54969: [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput
implementation
https://bugs.webkit.org/show_bug.cgi?id=54969

Attachment 83828: Patch
https://bugs.webkit.org/attachment.cgi?id=83828&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83828&action=review

Pls fix EWS breakage and help to unduplicate.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:2298
> +// This function is copied from /WebKit2/WebPage/mac/WebPageMac.mm.

Sounds like this should just live in WebCore. There's nothing WebKitty here.
Can you move and unduplicate?

> Source/WebKit/chromium/src/WebFrameImpl.cpp:2325
> +bool WebFrameImpl::getLocationAndLengthFromRange(Range* range, unsigned&
location, unsigned& length) const

Ditto.

> Source/WebKit/chromium/src/mac/WebTextHelper.mm:74
> +// This function is copied from
/WebKit/mac/Misc/WebNSAttributedStringExtras.mm.

Can we just compile WebNSAttributedStringExtras.mm?