[webkit-reviews] review granted: [Bug 55412] Frequent crashes in CFURLCache code on Snow Leopard : [Attachment 84125] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 14:50:04 PST 2011


mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 55412: Frequent crashes in CFURLCache code on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=55412

Attachment 84125: proposed fix
https://bugs.webkit.org/attachment.cgi?id=84125&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=84125&action=review

> Source/WebKit2/ChangeLog:18
> +	   like have liked trailing slash).

extra “like”

> Source/WebKit2/Shared/WebProcessCreationParameters.h:83
> +    // FIXME: These should not be merged with CFURLCache counterparts below.


not?

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:85
> +   
ASSERT(parameters.nsURLCachePath.data()[strlen(parameters.nsURLCachePath.data()
) - 1] != '/'); // Necessary for NSURLCache to find the cache file.

Should we assert that strlen(…) is > 0 first?

> Source/WebKit2/UIProcess/win/WebContextWin.cpp:68
> +    if (parameters.cfURLCachePath[parameters.cfURLCachePath.length() - 1] ==
'/')

and here


More information about the webkit-reviews mailing list