[webkit-reviews] review denied: [Bug 55095] IndexedDB: fire versionchange events when calling setVersion : [Attachment 84099] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 55095: IndexedDB: fire versionchange events when calling setVersion
https://bugs.webkit.org/show_bug.cgi?id=55095

Attachment 84099: Patch
https://bugs.webkit.org/attachment.cgi?id=84099&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84099&action=review

almost there

> Source/WebCore/storage/IDBDatabase.h:90
> +    virtual bool dispatchEvent(PassRefPtr<Event>);

usually we dont' interleave virtual and non-virtual...but this is going away
anyway

> Source/WebCore/storage/IDBDatabaseCallbacks.h:2
> + * Copyright (C) 2010 Google Inc. All rights reserved.

2011

> Source/WebCore/storage/IDBDatabaseCallbacks.h:10
> + * 2.  Redistributions in binary form must reproduce the above copyright

Use the 2 clause license here and elsewhere:
http://www.webkit.org/coding/bsd-license.html

> Source/WebKit/chromium/public/WebIDBDatabaseCallbacks.h:2
> + * Copyright (C) 2010 Google Inc. All rights reserved.

2011

> Source/WebKit/chromium/src/IDBDatabaseCallbacksProxy.cpp:2
> + * Copyright (C) 2010 Google Inc. All rights reserved.

2011

> Source/WebKit/chromium/src/IDBDatabaseCallbacksProxy.cpp:34
> +#if ENABLE(INDEXED_DATABASE)

move between #includes

> Source/WebKit/chromium/src/IDBDatabaseCallbacksProxy.h:2
> + * Copyright (C) 2010 Google Inc. All rights reserved.

2011

> Source/WebKit/chromium/src/IDBDatabaseCallbacksProxy.h:32
> +#include "IDBDatabaseCallbacks.h"

move inside guard

> Source/WebKit/chromium/src/IDBDatabaseCallbacksProxy.h:37
> +#include <wtf/PassRefPtr.h>

do you need this?

> Source/WebKit/chromium/src/WebIDBDatabaseCallbacksImpl.cpp:2
> + * Copyright (C) 2010 Google Inc. All rights reserved.

2011

> Source/WebKit/chromium/src/WebIDBDatabaseCallbacksImpl.cpp:29
> +

extra newline

> Source/WebKit/chromium/src/WebIDBDatabaseCallbacksImpl.h:2
> + * Copyright (C) 2010 Google Inc. All rights reserved.

2011

> Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp:102
> +    // use saved callbacks

Use full sentences.  Don't say what you're doing, say why.

> Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp:108
> +    m_databaseCallbacks = IDBDatabaseCallbacksProxy::create(callbacks);

ASSERT(!m_databaseCallbacks) first