[webkit-reviews] review denied: [Bug 48636] [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String : [Attachment 82840] patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied qi
<qi.2.zhang at nokia.com>'s request for review:
Bug 48636: [Qt] Mobile Devices should include Model and Firmware Version in
Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Attachment 82840: patch
https://bugs.webkit.org/attachment.cgi?id=82840&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Cross-posting from the Gecko discussion
(https://bugzilla.mozilla.org/show_bug.cgi?id=595669)

1./ From the Android 2.3 Compatibility Definition it is clear that Android
mandates reporting the DeviceModel -
(http://source.android.com/compatibility/android-2.3-cdd.pdf):

The user agent string reported by the WebView MUST be in this format:

Mozilla/5.0 (Linux; U; Android $(VERSION); $(LOCALE); $(MODEL) Build/$(BUILD))
AppleWebKit/533.1 (KHTML, like
Gecko) Version/4.0 Mobile Safari/533.1

2./ IE for Windows Phone mandates DeviceModel section - 
http://blogs.msdn.com/b/iemobile/archive/2010/03/25/ladies-and-gentlemen-please
-welcome-the-ie-mobile-user-agent-string.aspx.

3./ Device manufactures (e.g. Nokia) typically includes DeviceModel.

I think there is a real need for an HTTP request to identify the device, and
the DeviceModel in the user agent string seems to be the most commonly used
approach today.  

The DeviceModel could be considered the %Subplatform% for some (all?) mobile
platforms, which would fit nicely into our WebKit UA template.

When it comes to the patch attached, I do agree that on desktop (non-mobile)
platforms QtWebKit should not report the systemDeviceInfo.model just because
QtWebKit was built with QtMobility libraries available. I will mark the patch
r- for this specific reason.

I think we should only report the model info for specific mobile platforms
(e.g. Symbian; MeeGo). For these mobile platforms the "%Platform%" part of the
UA string should be specific to the mobile platform as well (e.g report "MeeGo"
as the platform, instead of Linux or X11 - as MeeGo implies Linux already, just
like Android would).