[webkit-reviews] review denied: [Bug 48127] [Qt][WK2] Plugin initialization : [Attachment 84079] Patch - partII

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 48127: [Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127

Attachment 84079: Patch - partII
https://bugs.webkit.org/attachment.cgi?id=84079&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84079&action=review

I'm going to go ahead and mark this as r- because it didn't build on Windows.
Please upload a new patch and I'll r+ it.

> Source/WebKit2/Shared/Plugins/PluginQuirks.h:42
> +	   RequiresGTKToolKit,

Please add a comment to this quirk that explain what it's for and why it's
necessary.

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:490
> +		  *reinterpret_cast<uint32_t*>(value) = 2;

Please add a comment explaining what "2" means here, or maybe put it in a
constant.