[webkit-reviews] review granted: [Bug 55338] applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle : [Attachment 84014] cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 28 11:02:35 PST 2011
Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 55338: applyInlineStyleToPushDown and removeInlineStyleFromElement should
take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55338
Attachment 84014: cleanup
https://bugs.webkit.org/attachment.cgi?id=84014&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84014&action=review
> Source/WebCore/editing/ApplyStyleCommand.cpp:1229
> -
> +
Nit: Did you mean to add spaces here?
> Source/WebCore/editing/EditingStyle.cpp:327
> + ExceptionCode ec;
> + m_mutableStyle->setProperty(propertyID, value, important, ec);
Do we need to check or assert the exception code here?
> Source/WebCore/editing/EditingStyle.h:39
> +#include <wtf/text/WTFString.h>
Why is this needed?
More information about the webkit-reviews
mailing list