[webkit-reviews] review granted: [Bug 54942] In layout tests, iframe's onload handler should not use script function defined after the iframe : [Attachment 83790] path to fix more tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 10:35:24 PST 2011


Tony Gentilcore <tonyg at chromium.org> has granted Xianzhu Wang
<wangxianzhu at google.com>'s request for review:
Bug 54942: In layout tests, iframe's onload handler should not use script
function defined after the iframe
https://bugs.webkit.org/show_bug.cgi?id=54942

Attachment 83790: path to fix more tests
https://bugs.webkit.org/attachment.cgi?id=83790&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
Thanks again for working on these. I went through the tests as carefully as I
could and can't find anything that looks like it might be changing the intent
of the test.

For future reference, if you have more patches in this area, please open a
separate bug for each. If you want to tie them all together, you can have a
master meta bug and mark each bug with your patches as blocking that master
bug.


More information about the webkit-reviews mailing list