[webkit-reviews] review denied: [Bug 54910] media/video-replaces-poster.html fails on all platforms : [Attachment 83929] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 54910: media/video-replaces-poster.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=54910

Attachment 83929: Patch
https://bugs.webkit.org/attachment.cgi?id=83929&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83929&action=review

This change defeats the purpose of the test, to ensure that the poster image is
replaced by a frame of video, because the poster is displayed until playback
begins or a seek occurs (see https://bugs.webkit.org/show_bug.cgi?id=37591).

Seeking to some time and seeking back to time 0 may work, though I don't see
why that would be different from seeking to 1 as the current test does.

> LayoutTests/media/video-replaces-poster.html:13
> -		   video.pause();
> -		   video.currentTime = 1;  // so the snapshot always has the
same frame.
> +		   video.currentTime = 0;  // so the snapshot always has the
same frame.

Do you have a theory about why a snapshot at time 0 works better than a
snapshot at 1 second?