[webkit-reviews] review denied: [Bug 55214] [Qt]tst_QDeclarativeWebView - 8 test cases fail : [Attachment 84064] After the previous patch there is still two failures.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 08:28:59 PST 2011


Andreas Kling <kling at webkit.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 55214: [Qt]tst_QDeclarativeWebView - 8 test cases fail
https://bugs.webkit.org/show_bug.cgi?id=55214

Attachment 84064: After the previous patch there is still two failures.
https://bugs.webkit.org/attachment.cgi?id=84064&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84064&action=review

Looks good, just a tiny thing:

> Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:60
> +    view.page()->mainFrame()->load(QUrl("qrc:///resources/sample.html"));

view.load()

> Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:74
> +    view.page()->mainFrame()->load(QUrl("qrc:///resources/sample.html"));

Ditto.


More information about the webkit-reviews mailing list