[webkit-reviews] review denied: [Bug 55360] Web Inspector: add live edit test : [Attachment 84036] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55360: Web Inspector: add live edit test
https://bugs.webkit.org/show_bug.cgi?id=55360

Attachment 84036: Patch.
https://bugs.webkit.org/attachment.cgi?id=84036&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84036&action=review

> LayoutTests/ChangeLog:14
> +	   (f):

nuke this line.

> LayoutTests/http/tests/inspector/debugger-test.js:131
> +    InspectorTest.addResult("==Source frame contents start==");

I think there already is a highlighter test that is dumping text model content.
Should we add editor-test.js with utility there?

> LayoutTests/inspector/debugger/live-edit.html:21
> +		   sourceFrame._textViewer.editLine =
InspectorTest.safeWrap(function(element, callback)

You should not override text viewer methods - what if the bug is in that line?