[webkit-reviews] review granted: [Bug 51006] Range::processContents needs cleanup : [Attachment 82761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 00:48:54 PST 2011


Kent Tamura <tkent at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 51006: Range::processContents needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=51006

Attachment 82761: Patch
https://bugs.webkit.org/attachment.cgi?id=82761&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82761&action=review

> Source/WebCore/dom/Range.cpp:630
> +    // This switch statement must be consistent with that of
Range::processContentsBetweenOffsets.

So, we had better add a comment to Range::processContentBetweenoffsets().

> Source/WebCore/dom/Range.cpp:760
> +    // This switch statement must be consistent with that of
lengthOfContentsInNode.

ditto.


More information about the webkit-reviews mailing list