[webkit-reviews] review requested: [Bug 55355] TextIterator should not be a friend of RenderTextControl : [Attachment 84024] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 00:18:31 PST 2011


Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 55355: TextIterator should not be a friend of RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=55355

Attachment 84024: Patch
https://bugs.webkit.org/attachment.cgi?id=84024&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
Simple patch: remove need for friend-clause by making innerTextElement()
public. Even after the general new-shadow-DOM refactoring there will be a
common inner text element, so the accessor will likely stay around. We might
want to restrict visibility of the shadow DOM from RenderTextControl, but this
is for yet another (larger) refactoring.


More information about the webkit-reviews mailing list