[webkit-reviews] review denied: [Bug 55341] Add lineboundary editing/selection/extend-selection test : [Attachment 84010] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Benjamin (Ben) Kalman
<kalman at chromium.org>'s request for review:
Bug 55341: Add lineboundary editing/selection/extend-selection test
https://bugs.webkit.org/show_bug.cgi?id=55341

Attachment 84010: Patch
https://bugs.webkit.org/attachment.cgi?id=84010&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84010&action=review

(In reply to comment #6)
> home-end is badly named, it should be lineboundary.
> 
> Consider it an obsoletion rather than a modification.

I'm not sure.  home-end signifies the fact we're testing the behavior of home
and end keys wheres line-boundary doesn't.  I don't think new name is
significantly better.  In general, I'm hesitant to rename tests unless there's
a really compelling reason to do so.  For example, flakiness dashboard will
lose all test results if we did this rename.

> LayoutTests/ChangeLog:32
> +2011-02-27  Benjamin Kalman	<kalman at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add lineboundary editing/selection/extend-selection test
> +	   https://bugs.webkit.org/show_bug.cgi?id=55341
> +
> +	   This is the same as most other extend-selection tests where
everything is done in the script test.
> +	   A lineboundary version of the test didn't initially exist due to RTL
bugs, which have now been fixed.
> +
> +	   * editing/selection/extend-selection-lineboundary-expected.txt:
Added.
> +	   * editing/selection/extend-selection-lineboundary.html: Added.
> +

Nit: old change log.