[webkit-reviews] review granted: [Bug 55303] [Qt] Use WTF ref counting for FontPlatformDataPrivate : [Attachment 83951] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 27 04:46:50 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 55303: [Qt] Use WTF ref counting for FontPlatformDataPrivate
https://bugs.webkit.org/show_bug.cgi?id=55303

Attachment 83951: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=83951&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83951&action=review

Nice!

> Source/WebCore/platform/graphics/qt/FontPlatformData.h:101
> +	       return 0;

Nice, fixing style as well :-)

> Source/WebCore/platform/graphics/qt/FontPlatformData.h:137
> +	   // WebKit allows font size zero but QFont does not.

WebCore allows a font size of zero, but QFont does not.


More information about the webkit-reviews mailing list