[webkit-reviews] review requested: [Bug 54406] png-1.5 fixes : [Attachment 83972] Patch implementing review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 27 04:42:07 PST 2011


Thomas Klausner <tk at giga.or.at> has asked  for review:
Bug 54406: png-1.5 fixes
https://bugs.webkit.org/show_bug.cgi?id=54406

Attachment 83972: Patch implementing review comments
https://bugs.webkit.org/attachment.cgi?id=83972&action=review

------- Additional Comments from Thomas Klausner <tk at giga.or.at>
Thanks for the feedback, Patrick.

I've taken out the longjmp changes; they are not necessary. I was following the
new png style guide for this kind of code.

I've also implemented all your other suggestions. New patch attached.

(What does the color purple in the bubbles mean, like for "mac" for the
previous patch?)


More information about the webkit-reviews mailing list