[webkit-reviews] review denied: [Bug 48234] Size of text in popup menu doesn't match size of text in <select> itself in WebKit2 : [Attachment 83960] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Sam Weinig <sam at webkit.org>'s request for review:
Bug 48234: Size of text in popup menu doesn't match size of text in <select>
itself in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48234

Attachment 83960: Patch
https://bugs.webkit.org/attachment.cgi?id=83960&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=83960&action=review

r- since this breaks Qt and Windows. But please also consider my previous
comments and the next one.

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:53
> +    data.fontInfo.fontAttributeDictionary = fontDescriptorAttributes;
> +    data.fontInfo.fontOverrideSize = frame->pageScaleFactor() == 1 ? 0 :
([[font fontDescriptor] pointSize] * frame->pageScaleFactor());

The “override” concept seems unnecessarily cumbersome. Why not simply make a
mutable copy of the dictionary and change the font size attribute?
Alternatively, since the UI process knows the page scale factor, why not leave
this multiplication exercise up to it