[webkit-reviews] review denied: [Bug 55252] [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed : [Attachment 83865] first try

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 55252: [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback
state gets changed
https://bugs.webkit.org/show_bug.cgi?id=55252

Attachment 83865: first try
https://bugs.webkit.org/attachment.cgi?id=83865&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83865&action=review

> Source/WebCore/ChangeLog:8
> +	   Need to involk a call back function to notify the HTMLMediaElement

s/involk/invoke/
s/call back/callback/

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:243
> +    // Don't send PlaybackChanged notification for pre-roll

Sentence style for comments (period at end missing.) :)

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:160
> +    bool m_ignorePlaybackChanged;

Not a fan of this name, m_suppressNextPlaybackChanged perhaps?
The fact that it only affects the next state change and then goes back to
normal should be reflected somehow.