[webkit-reviews] review granted: [Bug 13807] XML without style should render as syntax-highlighted source : [Attachment 83932] Patch with javascript fixes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 26 03:21:30 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 13807: XML without style should render as syntax-highlighted source
https://bugs.webkit.org/show_bug.cgi?id=13807

Attachment 83932: Patch with javascript fixes.
https://bugs.webkit.org/attachment.cgi?id=83932&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83932&action=review

> Source/WebCore/xml/XMLViewer.xsl:241
> +	   <span class="button expand-button" onmousedown="return
buttonMouseDown();">

return buttonMouseDown does not sound right, what are you trying to achieve?
But I think we can address it in a follow up patch.
Setting cq- since is likely to require careful landing.


More information about the webkit-reviews mailing list