[webkit-reviews] review denied: [Bug 55283] Make ScopeChainNode GC allocated : [Attachment 83911] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 25 23:37:16 PST 2011


Gavin Barraclough <barraclough at apple.com> has denied Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 55283: Make ScopeChainNode GC allocated
https://bugs.webkit.org/show_bug.cgi?id=55283

Attachment 83911: Patch
https://bugs.webkit.org/attachment.cgi?id=83911&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Per our discussion I suggest making scope chain an object so that it can hold
properties in anonymous slots, and do away with custom marking (also, function
should also be holding scope chain in an anonymous slot now).  As such I'm
going to r- for the time being.  Hope this sounds right to you, feel free to
argue we should land this as a cell for now if you thing this is a useful
stepping stone & I'll re-review.


More information about the webkit-reviews mailing list