[webkit-reviews] review granted: [Bug 55259] [chromium] Abstract "pixels with a graphics context" into its own class : [Attachment 83900] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 55259: [chromium] Abstract "pixels with a graphics context" into its own
class
https://bugs.webkit.org/show_bug.cgi?id=55259

Attachment 83900: Patch
https://bugs.webkit.org/attachment.cgi?id=83900&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83900&action=review

Looks awesome!	Usual sort of collection of nitpicks

> Source/WebCore/platform/graphics/chromium/PlatformCanvas.cpp:2
> + * Copyright (C) 2010 Google Inc. All rights reserved.

times they are a'changing. 2011 :)

> Source/WebCore/platform/graphics/chromium/PlatformCanvas.h:32
> +#if USE(SKIA)
> +namespace skia { class PlatformCanvas; }
> +class SkBitmap;
> +#endif

nit: move this after the #includes

> Source/WebCore/platform/graphics/chromium/PlatformCanvas.h:64
> +	   AutoLocker(PlatformCanvas*);

nit: explicit

> Source/WebCore/platform/graphics/chromium/PlatformCanvas.h:80
> +	   Painter(PlatformCanvas*);

nit: explicit