[webkit-reviews] review granted: [Bug 54774] [fileapi] Implement LocalFileSystem.resolveFileSystemURI : [Attachment 83844] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 54774: [fileapi] Implement LocalFileSystem.resolveFileSystemURI
https://bugs.webkit.org/show_bug.cgi?id=54774

Attachment 83844: Patch
https://bugs.webkit.org/attachment.cgi?id=83844&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83844&action=review

>> Source/WebCore/fileapi/DOMFileSystemBase.cpp:62
>> +	KURL originURL(ParsedURLString, url.path());
> 
> Note that though I've switched to completeURL() below, I haven't here.  Is
there any other URL-parsing code I should be calling? I can't really guarantee
anything about the contents of url.path() (certainly not that it's the output
of KURL::string()).  But passing in a Document and calling completeURL() here
is obviously the wrong thing to do.

Yeah, this case is harder.  You can try resolving it against a base URL of
"about:blank".	This is probably also ok for now.  I suspect we'll need to
revisit this line of code when we start deploying the URLString type more
widely.