[webkit-reviews] review granted: [Bug 55251] On Mac, need to remove misspell underline in Editor::learnSpelling(). : [Attachment 83874] Proposed patch (v1)

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted jpu at apple.com's request for review:
Bug 55251: On Mac, need to remove misspell underline in
Editor::learnSpelling().
https://bugs.webkit.org/show_bug.cgi?id=55251

Attachment 83874: Proposed patch (v1)
https://bugs.webkit.org/attachment.cgi?id=83874&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=83874&action=review

Not changing to cq+ because you may want to clarify the comment.

> Source/WebCore/editing/Editor.cpp:1771
> +    // FIXME: On Mac OS X, when use "learn" button on "Spelling and Grammar"
panel, we don't call this function. It should remove misspelling markers around
the learned word, see <rdar://problem/5396072>.

Seems like the second sentence in the comment isn’t needed anymore, because now
the function does what it should do.