[webkit-reviews] review granted: [Bug 55196] Add necessary build steps to JavaScriptGlue GYP project. : [Attachment 83830] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 55196: Add necessary build steps to JavaScriptGlue GYP project.
https://bugs.webkit.org/show_bug.cgi?id=55196

Attachment 83830: Patch
https://bugs.webkit.org/attachment.cgi?id=83830&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83830&action=review

This is great!	Thanks.

> Source/JavaScriptGlue/ChangeLog:12
> +	   * gyp/remove-headers-if-needed.sh: Added.
> +	   * gyp/run-if-exists.sh: Added.
> +	   * gyp/update-info-plist.sh: Added.

We'll probably want to move these up in the source tree so they can be shared
by multiple projects, but we can do that once we tackle the sharing problems.

> Source/JavaScriptGlue/gyp/run-if-exists.sh:4
> +if [ -f ../../Tools/Scripts/$1 ]; then
> +    ../../Tools/Scripts/$1 || exit $?;

It would be nice if we didn't have to hard-code the "../.." here.  Maybe
run-if-exists should take the fully relative path and then we can let GYP magic
figure out the depth?