[webkit-reviews] review denied: [Bug 55239] Allow webkitEnterFullScreen from outside user gesture when restrictions are unrestricted : [Attachment 83861] Updated patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Dean Jackson
<dino at apple.com>'s request for review:
Bug 55239: Allow webkitEnterFullScreen from outside user gesture when
restrictions are unrestricted
https://bugs.webkit.org/show_bug.cgi?id=55239

Attachment 83861: Updated patch
https://bugs.webkit.org/attachment.cgi?id=83861&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83861&action=review

> Source/WebCore/html/HTMLMediaElement.h:191
> +    void setRestrictions(BehaviorRestrictions restrictions) { m_restrictions
= restrictions; }

setRestrictions" is pretty generic, setBehaviorRestrictions maybe?


> Source/WebCore/html/HTMLVideoElement.cpp:235
> +    if ((!isUserGesture && requireUserGestureForFullScreen()) ||
!supportsFullscreen()) {

As long as you are making a change anyway, I think this will be slightly
clearer if you switch the order of the comparisons:
"(requireUserGestureForFullScreen() && !isUserGesture)"