[webkit-reviews] review granted: [Bug 55249] Leak in JSParser::Scope of ScopeLabelInfo Vector : [Attachment 83857] Added Destructor to clean up JSParser::Scope leak of ScopeLabelInfo Vector

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 55249: Leak in JSParser::Scope of ScopeLabelInfo Vector
https://bugs.webkit.org/show_bug.cgi?id=55249

Attachment 83857: Added Destructor to clean up JSParser::Scope leak of
ScopeLabelInfo Vector
https://bugs.webkit.org/attachment.cgi?id=83857&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83857&action=review

I’d rather see m_labels be changed to an OwnPtr than just add the missing
deletion.

> Source/JavaScriptCore/parser/JSParser.cpp:300
> +	       if (m_labels)
> +		   delete m_labels;

The if isn’t needed. C++ defines the delete operator to do nothing if the
pointer passed is null.