[webkit-reviews] review granted: [Bug 55224] old-run-webkit-test's Windows registry code is ugly : [Attachment 83823] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 25 10:38:57 PST 2011
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 55224: old-run-webkit-test's Windows registry code is ugly
https://bugs.webkit.org/show_bug.cgi?id=55224
Attachment 83823: Patch
https://bugs.webkit.org/attachment.cgi?id=83823&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review
r=me
> Tools/Scripts/old-run-webkit-tests:2607
> + my ($valueName) = @_;
Maybe $key instead of $valueName?
> Tools/Scripts/old-run-webkit-tests:2614
> + my ($valueName, $data) = @_;
Maybe ($key, $value) instead of ($valueName, $data)?
More information about the webkit-reviews
mailing list