[webkit-reviews] review requested: [Bug 53146] [GTK] Combo boxes should emit object:selection-changed even when collapsed : [Attachment 83786] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 53146: [GTK] Combo boxes should emit object:selection-changed even when
collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

Attachment 83786: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=83786&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Ok, here we go again... strike 3!

I've changed the code, once again, this time to directly compare the list
object currently used with the list object used before, so if they're not the
same we assume further comparisons make no sense. Semantically it's the same
than asking for the parentObject() of a listBox option object, but without
having to call oldFocusedObject->parentObject(), which was what was causing the
failure before.

I've tested locally and couldn't reproduce crashes anymore. Also Philippe (who
was able to reproduce the crashes always in a more reliable way) tested this
new patch and confirms he doesn't get crashes anymore, so I hope this time will
be "the good one (tm)"

Sorry for the hassle.