[webkit-reviews] review requested: [Bug 55119] Implement SVGColor/SVGPaint API : [Attachment 83782] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 25 00:45:34 PST 2011


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 55119: Implement SVGColor/SVGPaint API
https://bugs.webkit.org/show_bug.cgi?id=55119

Attachment 83782: Patch
https://bugs.webkit.org/attachment.cgi?id=83782&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
This patch completly implements the SVGPaint/SVGColor API, except that any
mutation of this object, is not live, it doesn't take effect on screen, nor is
it visible in the computed style.
CSSValue has no concept of being mutable, a follow-up patch will add
CSSMutableValue, and fix the problem for real, though I'm splitting up the
patches, in order to keep them in moderate size.
(Note: this patch is large because of the new tests, mostly)


More information about the webkit-reviews mailing list