[webkit-reviews] review granted: [Bug 55204] malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement : [Attachment 83774] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 55204: malloc in removeChildren shows up on profile of peacekeeper
domDynamicCreationCreateElement
https://bugs.webkit.org/show_bug.cgi?id=55204

Attachment 83774: Patch
https://bugs.webkit.org/attachment.cgi?id=83774&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83774&action=review

r=me

> Source/WebCore/dom/ContainerNode.cpp:359
> +    // FIXME: We should tune the inlineCapacity.  Having this function call
malloc
> +    // as a result of needing to expand capacity is expensive an shows up on
benchmarks.

This FIXME is probably not super helpful. Just do your best to tune it now.
Someone else can always tune more later.

> Source/WebCore/dom/ContainerNode.cpp:521
> +    // FIXME: We should tune the inlineCapacity.  Having this function call
malloc
> +    // as a result of needing to expand capacity is expensive an shows up on
benchmarks.

Ditto.

> Source/WebCore/dom/ContainerNode.cpp:524
> +    // childNodeCount() results in a full walk of the nodes, but should be
faster
> +    // than having to malloc twice if we have lots of kids.

Dup of a previous comment - maybe this version can be shorter?