[webkit-reviews] review granted: [Bug 54152] typing enter in the input element should not fire textInput : [Attachment 83767] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 54152: typing enter in the input element should not fire textInput
https://bugs.webkit.org/show_bug.cgi?id=54152

Attachment 83767: Patch
https://bugs.webkit.org/attachment.cgi?id=83767&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83767&action=review

> LayoutTests/fast/forms/textinput-not-fired-on-enter-in-input.html:58
> +} else {
> +    log('This test requires eventSender to run in LayoutTests.');
> +}

Given that you have instructions to run it manually, I don't see that this log
comment adds anything. Any test runner that is running WebKit's layout tests
will have eventSender. The only reason we check for eventSender is for running
the test manually.

If you really want to keep this in though, WebKit style for one-line else
statements is to leave off the brackets.