[webkit-reviews] review granted: [Bug 55184] WebKit2: Image-based cursors do not work : [Attachment 83722] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 17:17:24 PST 2011


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 55184: WebKit2: Image-based cursors do not work
https://bugs.webkit.org/show_bug.cgi?id=55184

Attachment 83722: Patch
https://bugs.webkit.org/attachment.cgi?id=83722&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83722&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.h:206
> +	   if (cursor.type() != WebCore::Cursor::Custom)

This should be type instead of cursor.type().

> Source/WebKit2/Shared/WebCoreArgumentCoders.h:236
> +	       return false;

You could check that the hot spot is actually inside the image here.


More information about the webkit-reviews mailing list