[webkit-reviews] review granted: [Bug 55002] rebaseline-chromium-webkit-tests can't handle GPU variants at all : [Attachment 83401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 15:39:22 PST 2011


Mihai Parparita <mihaip at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 55002: rebaseline-chromium-webkit-tests can't handle GPU variants at all
https://bugs.webkit.org/show_bug.cgi?id=55002

Attachment 83401: Patch
https://bugs.webkit.org/attachment.cgi?id=83401&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83401&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:148
> +    def test_platform_names(self):

Might be nice if the the GPU-specific behavior was done via a mixin so that
there wouldn't be quite so much repetition, though that's beyond the scope of
this patch.


More information about the webkit-reviews mailing list