[webkit-reviews] review granted: [Bug 55183] Expand ruby base when it is shorter than the ruby text : [Attachment 83719] Justify and inset ruby base

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 55183: Expand ruby base when it is shorter than the ruby text
https://bugs.webkit.org/show_bug.cgi?id=55183

Attachment 83719: Justify and inset ruby base
https://bugs.webkit.org/attachment.cgi?id=83719&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83719&action=review

r=me

> Source/WebCore/rendering/RenderBlock.h:493
> +    virtual ETextAlign alignmentForLine(bool endsWithSoftBreak) const;

I think the method name here sounds ambiguous.	I'd prefer textAlignmentForLine
so that nobody can confuse it with vertical-align.