[webkit-reviews] review granted: [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images. : [Attachment 83707] Addressing David's comments in the modified patch.

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 48781: Add a resourceload delegate method to query if WebCore should paint
the default broken image for failed images.
https://bugs.webkit.org/show_bug.cgi?id=48781

Attachment 83707: Addressing David's comments in the modified patch.
https://bugs.webkit.org/attachment.cgi?id=83707&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83707&action=review

r=me

> LayoutTests/fast/images/support-broken-image-delegate.html:26
> +    result.innerHTML = "FAIL";

Nit: Would be nice to differentiate this FAIL message from the one in loaded():


    result.innerHTML = "FAIL: onLoad event fired. Expected onError event.";