[webkit-reviews] review denied: [Bug 50222] [Qt] QML WebView inside a Flickable shows checkers pattern at startup : [Attachment 83691] Took care of comments from reviewer

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has denied Gopal Raghavan
<gopal.1.raghavan at nokia.com>'s request for review:
Bug 50222: [Qt] QML WebView inside a Flickable shows checkers pattern at
startup
https://bugs.webkit.org/show_bug.cgi?id=50222

Attachment 83691: Took care of comments from reviewer
https://bugs.webkit.org/attachment.cgi?id=83691&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83691&action=review

> Source/WebKit/qt/ChangeLog:10
> +

This patch fixes the checkerboard visible at startup even if preferredWidth and
preferredHeight are not set.

seems a better changelog. I'm nitpicking :).

> Source/WebKit/qt/tests/util.h:37
> +

Why this extra line?

> Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:41
> +    delete wv;

You don't need those deletes. component.create(); return a pointer and indeed
allocate memory BUT everything is deleted anyway when QDeclarativeComponent
dies (at the end of the scope) and when the QDeclarativeEngine dies because the
root element is parented to them. I'm sure it can cause problem of double
deletion (valgrind can confirm) but I guess probably that use case is catched
so that's why it works.