[webkit-reviews] review granted: [Bug 55105] Make weaklist processing deal with weak handles being removed during the iteration : [Attachment 83679] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 55105: Make weaklist processing deal with weak handles being removed during
the iteration
https://bugs.webkit.org/show_bug.cgi?id=55105

Attachment 83679: Patch
https://bugs.webkit.org/attachment.cgi?id=83679&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83679&action=review

Please put up a new patch & ping me if you think these changes need a rereview,
but r+ with changes above.

> Source/JavaScriptCore/collector/handles/HandleHeap.cpp:82
> +	   

Please to be removing the whitespace change!

> Source/JavaScriptCore/collector/handles/HandleHeap.cpp:97
> +	       m_nextToFinalize = &node;
> +	       deallocate(toHandle(current));
> +	       node = *m_nextToFinalize;
> +	       m_nextToFinalize = 0;

Per our discussion, since current cannot == node, can remove the
m_nextToFinalize dance & replace with an ASSERT.

> Source/JavaScriptCore/collector/handles/HandleHeap.h:124
> +    Node** m_nextToFinalize;

Per discussion, it seems this can be a Node* rather than a Node**.