[webkit-reviews] review granted: [Bug 55157] Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code. : [Attachment 83674] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 55157: Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate
code.
https://bugs.webkit.org/show_bug.cgi?id=55157

Attachment 83674: Patch
https://bugs.webkit.org/attachment.cgi?id=83674&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
I like the code simplification here, but I don't so much like
RenderTheme::volumeSliderOffsetFromMuteButton changing to RenderTheme::
volumeSliderOffset because the new name says nothing about what the offset is
relative to. Please consider a more descriptive name:
volumeSliderOffsetRelativeToMuteButton, volumeSliderOffsetFromMuteButton, ...