[webkit-reviews] review denied: [Bug 55116] generate a times.json file when running layout tests : [Attachment 83613] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 55116: generate a times.json file when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=55116

Attachment 83613: Patch
https://bugs.webkit.org/attachment.cgi?id=83613&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83613&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:18
4
> +	   # Convert floats from seconds into milliseconds.
> +	   float_format = lambda o, allow_nan=True: format(o * 1000, '.0f')

Why don't we just do this conversion when adding values to self._test_timings
(or in get_times())?  This avoids having to add an optional param to
_generate_json_file and the hackery of setting encoder.floatstr.

Also, the comment and the changelog disagree about the format of the map (is it
seconds on ms?).