[webkit-reviews] review granted: [Bug 55146] Assertion failure in FrameLoadDelegate::locationChangeDone when running http/tests/navigation/back-twice-without-commit.html : [Attachment 83659] Change FrameLoadDelegate to support any number of concurrent timers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 08:20:59 PST 2011


Darin Adler <darin at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 55146: Assertion failure in FrameLoadDelegate::locationChangeDone when
running http/tests/navigation/back-twice-without-commit.html
https://bugs.webkit.org/show_bug.cgi?id=55146

Attachment 83659: Change FrameLoadDelegate to support any number of concurrent
timers
https://bugs.webkit.org/attachment.cgi?id=83659&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83659&action=review

> Tools/DumpRenderTree/win/FrameLoadDelegate.cpp:220
> +    COMPtr<FrameLoadDelegate> d = timerMap().take(id);

Are timer IDs guaranteed to not be 0 or -1?


More information about the webkit-reviews mailing list