[webkit-reviews] review denied: [Bug 55143] Web Inspector: Huge fonts in font preview : [Attachment 83653] [PATCH] Suggested fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 55143: Web Inspector: Huge fonts in font preview
https://bugs.webkit.org/show_bug.cgi?id=55143

Attachment 83653: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=83653&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83653&action=review

> Source/WebCore/inspector/front-end/FontView.js:56
> +	   var uniqueFontName = "WebInspectorFontPreview" +
WebInspector.FontView._nextFontId();

Nit: No need for a method here, just inline it.

> Source/WebCore/inspector/front-end/FontView.js:93
> +	   var display = element.style.display;

You should encapsulate font metrics and use dummy element added to body,
positioned absolutely, behind the screen.