[webkit-reviews] review granted: [Bug 55142] Make it possible to test the targetdensity-dpi support : [Attachment 83648] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 55142: Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142

Attachment 83648: Patch
https://bugs.webkit.org/attachment.cgi?id=83648&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83648&action=review

r=me with moans:

> Source/WebKit/qt/ChangeLog:9
> +	   Test the viewport meta tag feature targetdensity-dpi by
> +	   adding a new extra arguments to dumpConfigurationForViewpor

<kenneth repeat="all ChangeLogs">
...adding extra arguments...
Typo, dumpConfigurationForViewport
</kenneth>

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:187
> -    static QString viewportAsText(QWebPage*, const QSize&);
> +    static QString viewportAsText(QWebPage*, int, const QSize&, const
QSize&);

Variable names would be useful here.

> Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:238
> -void LayoutTestController::dumpConfigurationForViewport(int availableWidth,
int availableHeight)
> +void LayoutTestController::dumpConfigurationForViewport(int dpi, int width,
int height, int availableWidth, int availableHeight)

dpi -> deviceDPI