[webkit-reviews] review denied: [Bug 53546] When frame flattening is on iframe outside viewport is not flattened : [Attachment 80954] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 02:48:11 PST 2011


Eric Seidel <eric at webkit.org> has denied Misha <Michael.Tyutyunik at nokia.com>'s
request for review:
Bug 53546: When frame flattening is on iframe outside viewport is not flattened
https://bugs.webkit.org/show_bug.cgi?id=53546

Attachment 80954: patch
https://bugs.webkit.org/attachment.cgi?id=80954&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80954&action=review

How do we test this?

> Source/WebCore/ChangeLog:6
> +During initial layout when frame flattening is on contents size is not set
yet. Becuase of this the check that the frame is not offscreen is failing and
flattenFrame() returns false which cause layout go without frame flattening. 

Indent?  and maybe a little wrapping :)


More information about the webkit-reviews mailing list