[webkit-reviews] review granted: [Bug 44797] fullscreen javascript bindings not implemented for v8 : [Attachment 83561] Addressed Darin's feedback. TODO -> FIXME
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 24 02:41:38 PST 2011
Eric Seidel <eric at webkit.org> has granted David Dorwin <ddorwin at chromium.org>'s
request for review:
Bug 44797: fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797
Attachment 83561: Addressed Darin's feedback. TODO -> FIXME
https://bugs.webkit.org/attachment.cgi?id=83561&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83561&action=review
Seems reasonable.
> Source/WebKit/chromium/src/ChromeClientImpl.cpp:886
> + // FIXME: Implement.
we have a notImplemented() call which may be more useful than a FIXME.
More information about the webkit-reviews
mailing list