[webkit-reviews] review denied: [Bug 54876] Web Inspector: [Text editor] Bug in the highlighter : [Attachment 83302] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at google.com>'s request for review:
Bug 54876: Web Inspector: [Text editor] Bug in the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54876

Attachment 83302: Patch
https://bugs.webkit.org/attachment.cgi?id=83302&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83302&action=review

This looks good. r- for timeout, as we agreed.

> LayoutTests/inspector/editor/highlighter-long-line.html:30
> +	   function() {

"{" on the next line.

function()
{
}

> LayoutTests/inspector/editor/highlighter-long-line.html:47
> +	   function() {

ditto

> LayoutTests/inspector/editor/highlighter-paste-in-comment.html:24
> +	   function() {

ditto (and below)

> LayoutTests/inspector/editor/highlighter-test.js:22
> +InspectorTest.waitForAllTimeouts = function(runnable, callback)

As we agreed, let's change the source code API for better testability.