[webkit-reviews] review granted: [Bug 54971] Web Inspector: it should be possible to pass custom error text from a backend method to frontend. : [Attachment 83620] [patch] second version.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 02:06:17 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 54971: Web Inspector: it should be possible to pass custom error text from
a backend method to frontend.
https://bugs.webkit.org/show_bug.cgi?id=54971

Attachment 83620: [patch] second version.
https://bugs.webkit.org/attachment.cgi?id=83620&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83620&action=review

One thing would improve this change: if you could replace String* with
ErrorString* and accompany it with typedef String ErrorString, that would
improve error handling visibility to the agent authors.

> Source/WebCore/ChangeLog:5
> +	   Web Inspector: There is a validator of the protocol message format.

Please add bug url into the changelog.

> Source/WebCore/ChangeLog:19
> +	   * inspector/InjectedScriptHost.cpp:

Not sure you need it all here, I would leave names of the files only.


More information about the webkit-reviews mailing list