[webkit-reviews] review denied: [Bug 44329] SH4 JIT SUPPORT : [Attachment 83614] CacheFlush

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied thouraya
<thouraya.andolsi at st.com>'s request for review:
Bug 44329: SH4 JIT SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=44329

Attachment 83614: CacheFlush
https://bugs.webkit.org/attachment.cgi?id=83614&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83614&action=review

Almost there, can you upload another one fixing my few nitpicks, I'll r+/cq+
it.

> Source/JavaScriptCore/ChangeLog:5
> +	   cacheFlush for SH4.

Provide an ExecutableAllocater::cacheFlush() implementation for Linux/SH4.

> Source/JavaScriptCore/jit/ExecutableAllocator.h:321
> +

One newline too much.

> Source/JavaScriptCore/jit/ExecutableAllocator.h:327
> +	   syscall(__NR_cacheflush, reinterpret_cast<unsigned int>(code), size,
CACHEFLUSH_D_WB | CACHEFLUSH_I | CACHEFLUSH_D_L2);
> +#else
> +	   syscall(__NR_cacheflush, reinterpret_cast<unsigned int>(code), size,
CACHEFLUSH_D_WB | CACHEFLUSH_I);

s/unsigned int/unsigned/