[webkit-reviews] review granted: [Bug 55113] Add a script for creating gypi files : [Attachment 83608] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 00:54:51 PST 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 55113: Add a script for creating gypi files
https://bugs.webkit.org/show_bug.cgi?id=55113

Attachment 83608: Patch
https://bugs.webkit.org/attachment.cgi?id=83608&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83608&action=review

Honestly, this is totally fine and doesn't really even need review.

> Tools/Scripts/make-gypi:43
> +    source_code_regexp = re.compile(r'\.(cpp|h)$')

I would have done this as an array of extensions, but this is OK too.


More information about the webkit-reviews mailing list