[webkit-reviews] review denied: [Bug 54807] Always explicitly use "signed" keyword to declare signed bitfields : [Attachment 83495] Updated

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 54807: Always explicitly use "signed" keyword to declare signed bitfields
https://bugs.webkit.org/show_bug.cgi?id=54807

Attachment 83495: Updated
https://bugs.webkit.org/attachment.cgi?id=83495&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
These look fine to me, although given that these places are likely
size-sensitive, I would add the COMPILE_ASSERT lines (as they should be easy to
add).  The only tricky part there is that that might make landing harder if
other compilers fail those checks.

The cpp.py change needs a test case.

Maybe you want to do these in separate patches?  r- for the lackof the cpp.py
test case.