[webkit-reviews] review granted: [Bug 37769] [Gtk] Flash item placed on wrong location right after load : [Attachment 83539] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 37769: [Gtk] Flash item placed on wrong location right after load
https://bugs.webkit.org/show_bug.cgi?id=37769

Attachment 83539: Patch
https://bugs.webkit.org/attachment.cgi?id=83539&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83539&action=review

Since the patch seems to clearly improve some broken cases I guess we can go
for it, but honestly we should either improve our tests or stop messing with
this code.

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:534
> +	   *(m_delayedAllocation.get()) = allocation;

Can't we just store a 'GtkAllocation' in the struct and copy the values? Seems
more straightforward.